Re: [libvirt] [PATCH 5/5] Update logging documentation
On Thu, Aug 06, 2009 at 09:59:56AM -0400, Amy Griffis wrote:
Mark McLoughlin wrote: [Thu Aug 06 2009, 08:25:06AM EDT]
> On Fri, 2009-07-31 at 17:57 -0400, Amy Griffis wrote:
> > + <p>Libvirtd does not reload its logging configuration when issued a
SIGHUP.
> > + If you want to reload the configuration, you must do a
<code>service
> > + libvirtd reload</code> or manually stop and restart the daemon
> > + yourself.</p>
>
> I guess that should be "service libvirtd restart" ?
>
> (i.e. all reload does is issue a SIGHUP)
Oh, I forgot I was looking at debian. :-) Their start script for
libvirtd actually does a restart under the reload. Generalizing
on "restart" for the docs would certainly cover all cases...
Ewww! They are separate actions for a reason ! Reload (via SIGHUP) is a
much less dangerous operation, than a full stop/start based restart. At
this point in time, a full restart should only be required for changes
to the daemon/driver config files libvirtd.conf, or qemu.conf. Everything
else (guest configs, etc) should just work with a mere SIGHUP. Someone
might like to fix 'reload' in Debian's initscripts...
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|