Re: [libvirt] [PATCH 06/17] genericxml2xml: add several graphics tests

On 05/05/2016 12:20 PM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com&gt; > --- > .../generic-graphics-vnc-listen-attr-only.xml | 28 ++++++++++++++++++++ > ...generic-graphics-vnc-listen-element-minimal.xml | 30 ++++++++++++++++++++++ > ...ic-graphics-vnc-listen-element-with-address.xml | 30 ++++++++++++++++++++++ > .../generic-graphics-vnc-manual-port.xml | 28 ++++++++++++++++++++ > .../generic-graphics-vnc-minimal.xml | 28 ++++++++++++++++++++ > .../generic-graphics-vnc-socket-listen.xml | 30 ++++++++++++++++++++++ > .../generic-graphics-vnc-socket.xml | 28 ++++++++++++++++++++ > .../generic-graphics-vnc-listen-attr-only.xml | 30 ++++++++++++++++++++++ > ...generic-graphics-vnc-listen-element-minimal.xml | 30 ++++++++++++++++++++++ > ...ic-graphics-vnc-listen-element-with-address.xml | 30 ++++++++++++++++++++++ > .../generic-graphics-vnc-manual-port.xml | 28 ++++++++++++++++++++ > .../generic-graphics-vnc-minimal.xml | 28 ++++++++++++++++++++ > .../generic-graphics-vnc-socket-listen.xml | 30 ++++++++++++++++++++++ > .../generic-graphics-vnc-socket.xml | 28 ++++++++++++++++++++ > tests/genericxml2xmltest.c | 7 +++++ The generic XML parser doesn't have any restriction on duplicate <graphics type='vnc'/>, so these could be combined to possibly one XML file. I know there really isn't much precedent for that at the moment, but given the massive size of our test suite and the fact that much of the time is spent on redundant parsing and XML formatting, personally I'd like to see things move in that direction.