Re: [libvirt] [PATCH] Add support for multiple serial ports into the Xen driver

On 02/17/2011 02:37 AM, Michal Novotny wrote: Huh. rpl_open is a gnulib replacement for open(); I'm not sure why gnulib thinks open() needs replacing on Linux (unless it is trying to provide O_CLOEXEC support for older kernels). Was this an incremental build, where you had already built before updating to the latest libvirt.git, and just typed 'make'? Can you try 'rm gnulib/lib/fcntl.h', then 'make', to see if it clears up the issue? If it doesn't, then maybe you'll have to resort to a full-blown clean checkout. It's defined by gnulib, which is copied into place from the gnulib.git submodule during ./autogen.sh (and not under libvirt.git's control). Even then, it only exists in the replacement <fcntl.h> header provided by gnulib when gnulib thinks that open() isn't up to snuff with POSIX requirements. I think the key is the <target port='1'/>. You don't need any placeholder in the XML for a missing port 0, but you do need it in the xm format where port is implied by position. That is: <devices> <serial type='dev'> <source path='/dev/ttyS1'/> <target port='1'/> </serial> </devices> should be sufficient XML to mark that you want to use multi-serial xen support, and that you are explicitly leaving virtual port 0 unoccupied and plugging in your one serial device into virtual port 1; mapping to: serial = [ "none", "/dev/ttyS1" ] in the xm file. The sexpr rationale should be the same. -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org