Re: [Libvir] [PATCH] virDomainMigrate version 4 (for discussion only!)
On Tue, Jul 24, 2007 at 01:25:31PM +0100, Richard W.M. Jones wrote:
Daniel P. Berrange wrote:
>I agree - the fact that the 'uri' to virConnectOpen doesn't technically
>have to
>always be a URI (eg, NULL, or Xen, or xen) is a major cause of pain
>virt-manager
>since we have to special case parsing of it, rather than just handing off
>to a
>generic URI parser module. We should mandate wellformed URIs for the
>migrate
>API, where wellformed is defined to be whatever libxml is able to parse :-)
I'd be a bit happier if libxml2 could parse a bare string like
"hostname" and "hostname:1234" more like my browser does. At the
moment
this is what it does:
With my libxml2 maintainer hat on: no
What libxml2 provides is are URI handling
hostname ---> scheme=(null) server=(null) port=0 path=hostname
query_raw=(null)
makes no sense. From an URI perspective "hostname" is a valid URI
Reference, it could not be interpreted in any other way.
hostname:1234 ---> scheme=hostname server=(null) port=0
path=(null)
query_raw=(null)
no better, "hostname:1234" is also a valid URI Reference
I'm sure there's some smartypants standards reason for it,
but it's
counterintuitive to me.
Your browser in general interprets "hostname" as an URI Reference
(hopefully), but the small window where an user can type something
relats more to guessing where you tried to direct him rather than
any sensible and predictable behaviour.
Again, sorry no, makes no sense from a libxml2 perspective.
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/