Re: [libvirt] [PATCH 2/6] normalize_xml: Implement the new API
On 01/09/2012 07:29 AM, Osier Yang wrote:
---
src/libvirt.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 52 insertions(+), 0 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index 896d151..223f07b 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -17867,3 +17867,55 @@ error:
virDispatchError(dom->conn);
return -1;
}
+
+/**
+ * virDomainNormalizeDeviceXML:
+ * @dom: Pointer to domain object
+ * @device_xml: Description of the device XML to be normalized
+ * @flags: currently unused, pass 0
We should definitely support VIR_DOMAIN_XML_INACTIVE off the bat, as
that affects the output that you will get from conf/domain_conf.c. And
since VIR_DOMAIN_XML_INACTIVE != VIR_INTERFACE_XML_INACTIVE, we have to
be careful how we represent things.
+ *
+ * Normalize the incoming device XML, and returned the formated XML.
s/formated/formatted/
+ *
+ * The mainly use of this function is to format the incoming device
s/mainly/main/
+ * XML as what the device is represented internally.
+ *
+ * Returns NULL in case of error, or the formated XML in case of success.
s/formated/formatted/
See my proposal in my reply to 0/6 for what I think would make a more
powerful API.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)