Re: [libvirt] [libvirt-php 0/3] small improvements
On 22.03.2016 11:04, Remi Collet wrote:
Le 18/03/2016 12:51, Vasiliy Tolstov a écrit :
> 2016-03-07 18:40 GMT+03:00 Vasiliy Tolstov <v.tolstov(a)selfip.ru>:
>> Add some more libvirt functions support to binding.
>> Also add some checks to prevent malloc SIZE_MAX memory
>> in case of errors
>>
>> Vasiliy Tolstov (3):
>> add some checks to prevent overflow
>> add block_commit support and needed const
>> add libvirt_domain_block_job_info
>>
>> src/libvirt-php.c | 152 ++++++++++++++++++++++++++++++++++++++++++++++++------
>> src/libvirt-php.h | 2 +
>> 2 files changed, 138 insertions(+), 16 deletions(-)
>
>
> Ping....
>
I have abolutely no idea what going with libvirt-php,
but FYI I have start a fork which is mostly ready and work with both PHP
5 and 7
If your patch is applied, sources will diverged, and it will be
nightmare to update the fork.
That's the trouble with forks. What led you to that decision? Does the
fork have any patches on the top of bare libvirt-php? If so, can they be
applied in the libvirt-php too?
Perhaps you can open a pull request against the fork, so we'll have a
single branch to merged upstream ?
Where does the fork live?
Michal