Re: [PATCH 2/2] libxl: Reject VM config referencing nwfilters
On Thu, Sep 12, 2024 at 15:54:04 -0600, Jim Fehlig wrote:
On 9/12/24 01:37, Peter Krempa wrote:
> On Wed, Sep 11, 2024 at 18:24:07 -0400, Laine Stump wrote:
> > On 9/11/24 5:02 PM, Jim Fehlig via Devel wrote:
[...]
> Thus doing validation in postParse is really valid only when
it's a new
> attribute or configuration that can't exist in "defined" state.
>
> In contrast the validate callback is applied in a limited set of XML
> entrypoints which then don't make the VM to vanish and certain other
> situations. For that reason the 'Validate' callback/step needs to be
> re-tried when starting the VM.
The validate callback plus a similar check at VM start is much nicer! I'll
add that to V2. Thanks!
At startup time the code should simply re-call the validate
infrastructure. We do that in the qemu driver so that there's no
duplication.
I'm not sure whether this was done in libxl, but that would be the
proper solution.