Re: [libvirt] [PATCH 2/2] qemu: move qemuDomainDefValidateVideo into qemuDomainDeviceDefValidateVideo
On 12/18/2017 10:35 AM, Laine Stump wrote:
qemuDomainDefValidateVideo() is just a loop performing various checks
on each video device. Rather than maintaining this outlyer function
*outlying
called from qemuDomainDefValidateVideo(), just fold the validations
into qemuDomainDeviceDefValidateVideo(), which is called once for each
video device (my guess is that ...DeviceDefValidateVideo() didn't
exist yet when ...DomainDefValidateVideo() was added, but I haven't
Everything between "(my guess is..." and "...verified this)." could
have
been below the ---
Anyway, the simple answer is qemuDomainDefValidateVideo was introduced
in 2.4 as commit id 133fb140 and qemuDomainDeviceDefValidateVideo was
introduced in 3.10 as commit id ab948b629. Thankfully gitk makes this
determination really easy! To take it one step further, I think you'll
recognize the committer of the original qemuDomainDeviceDefValidate
implementation in v2.0 as commit id d987f63a.
verified this).
---
I randomly noticed this when looking up something else in the validation code...
src/qemu/qemu_domain.c | 151 +++++++++++++++++++++----------------------------
1 file changed, 66 insertions(+), 85 deletions(-)
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John