Re: [libvirt] [PATCH 5/6] conf: tweak chain lookup internals

On 04/11/2014 12:21 AM, Eric Blake wrote: > Thanks to the testsuite, I feel quite confident that this rewrite > still gives the same results for all cases except for one, and > I can make the argument that _that_ case was a pre-existing bug. > When looking up relative names, the lookup is supposed to be > pegged to the directory that contains the parent qcow2 file. > > * src/util/virstoragefile.c (virStorageFileChainLookup): Depend on > new rather than old fields. > * tests/virstoragetest.c (mymain): Adjust test to match fix. > > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; > --- > src/util/virstoragefile.c | 49 +++++++++++++++++++---------------------------- > tests/virstoragetest.c | 3 +-- > 2 files changed, 21 insertions(+), 31 deletions(-) > ACK Although I'll admit I don't know enough about all the backing chain code to fully understand the "pre-existing" bug comment.

I suppose the only odd part I found was the comparison < VIR_STORAGE_TYPE_DIR - leaving currently DIR, NETWORK, and VOLUME out of the comparison. My thoughts went to what if something new comes along and what on earth was being compared beforehand...