Re: [libvirt] [PATCH V2] fix: unix sockets created for virtio-serail has insufficient permissions
On 09/03/2014 02:49 AM, Daniel P. Berrange wrote:
On Wed, Sep 03, 2014 at 02:18:07PM +0800, Chunyan Liu wrote:
> Add umask to _virCommand, allow user to set umask to command.
> Set umask(002) to qemu process to overwrite default umask(022) so
> that unix sockets created for virtio-serial has expected permissions.
>
ACK, you could possibly argue that it should be configurable in
qemu.conf, but I think that would be overkill. We unconditionally
put QEMU into a special group, so we really should make sure that
stuff is accessible to that group via umask.
Pushed with amended subject line. It would also be nice to enhance
tests/commandtest.c to cover this addition, but that can be a separate
patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 539 bytes)