Re: [libvirt] [jenkins-ci PATCH] Switch libvirt-dbus builds to Meson

On Mon, Sep 23, 2019 at 2:51 PM Daniel P. Berrangé <berrange(a)redhat.com&gt; wrote: > > On Mon, Sep 23, 2019 at 02:33:43PM +0200, Andrea Bolognani wrote: > > On Mon, 2019-09-23 at 13:23 +0200, Fabiano Fidêncio wrote: > > > name: libvirt-dbus > > > + # libvirt-dbus depends on meson 0.49.0 which is not available on > > > + # CentOS 7, Debian 9, Ubuntu 18; > > > machines: > > > - - libvirt-centos-7 > > > - - libvirt-debian-9 > > > - libvirt-debian-10 > > > - libvirt-debian-sid > > > - libvirt-fedora-29 > > > @@ -12,42 +12,15 @@ > > > - libvirt-freebsd-11 > > > - libvirt-freebsd-12 > > > - libvirt-freebsd-current > > > - - libvirt-ubuntu-16 > > > - - libvirt-ubuntu-18 > > > > Based on the discussion we had on libvir-list, our approach for CI > > should not be to drop target platforms on the basis that they doen't > > include a recent enough Meson, but rather to make a suitable Meson > > version available through other means such as pip. > > > > I would even go as far as arguing that implementing such a solution > > in libvirt-jenkins-ci is a pre-requisite, if not for merging the > > libvirt-dbus patches making the switch to Meson, certainly for > > cutting a release that includes them. > > > > The general understanding is that we only test what we claim to > > support and only claim to support what we test. There are some cases > > where we're not following this mantra to the letter, and efforts are > > already underway to address the most obvious ones, but that's no > > excuse to make the situation worse, especially considering that in > > the coming months we expect to move more and more projects to Meson. > > > > As a positive side-effect of figuring this out, we should be able to > > start building osinfo-db-tools again on platforms such as Ubuntu > > 18.04, dropping which I already though was problematic at the time. > > > > tl;dr NACK until we figure out how to do this without dropping > > several target platforms in the process > > In theory you can 'pip install meson'. The issue is likely to then > be whether ninja is available on the platform in question, as that's > a native app, not python. Just would like to point that using 'pip install meson' may be problematic as it'd always install the latest meson present in pip (which, in Debian 9's case would be 0.51.2 ... which *may* require a newer version of the Ninja than the one present in the system).