Re: [libvirt] [PATCH 38/41] cpu: Rework cpuHasFeature
On Tue, Aug 30, 2016 at 17:56:05 -0400, John Ferlan wrote:
On 08/12/2016 09:33 AM, Jiri Denemark wrote:
> The function is renamed to virCPUDataCheckFeature and another function
> (virCPUCheckFeature) which works on CPU definition rather than raw CPU
> data is introduced.
>
> Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
> ---
> src/cpu/cpu.c | 55 ++++++++++++++++++++++++++++++++++++-------
> src/cpu/cpu.h | 23 ++++++++++++++----
> src/cpu/cpu_arm.c | 1 -
> src/cpu/cpu_ppc64.c | 1 -
> src/cpu/cpu_s390.c | 1 -
> src/cpu/cpu_x86.c | 30 ++++++++++++++++++++---
> src/libvirt_private.syms | 3 ++-
> src/qemu/qemu_command.c | 2 +-
> src/qemu/qemu_domain.c | 7 ++++--
> src/qemu/qemu_parse_command.c | 2 +-
> src/qemu/qemu_process.c | 10 ++++----
> src/vmware/vmware_conf.c | 6 ++---
> tests/cputest.c | 6 ++++-
> 13 files changed, 113 insertions(+), 34 deletions(-)
>
Multiple things going on - too bad they couldn't be split... Still not
Hmm, looking at the patch now, it seems it could be split in two and one
hunk looks like it should go to an earlier patch. I'll look at this.
clear why cputest changes, but it's been a long road to get this
far so
I'm tired.
The cputest was changed to test both functions.
Jirka