Re: [libvirt] [PATCH v3 0/9] Selective block device migration implementation

On 06/01/2015 02:41 PM, John Ferlan wrote: >> And, `make` seems to fail here: >> >> $ ~/tinker-space/libvirt/./autogen.sh --system >> $ make -j4 >> [. . .] >> /home/kashyapc/tinker-space/libvirt/./src/qemu/qemu_migration.c: In function 'qemuMigrationRun': >> /home/kashyapc/tinker-space/libvirt/./src/qemu/qemu_migration.c:1997:17: error: 'format' may be used uninitialized in this function [-Werror=maybe-uninitialized] >> mon_ret = qemuMonitorDriveMirror(priv->mon, diskAlias, nbd_dest, >> ^ >> /home/kashyapc/tinker-space/libvirt/./src/qemu/qemu_migration.c:1971:21: note: 'format' was declared here >> const char *format; >> >> > > See my response to 3/9. > > If you initialize to NULL you'll be able to compile. But you'll end up corrupting your guest if your source has a qcow2 disk. The patch needs to be tweaked to mirror to NBD as "raw" rather than as the source's format.

>> PS: Apologies if this ends up being a double email, the first email >> was accidentally sent from my @fedoraproject.org address (which is >> not subscribed to this list). Unsubscribed mails can still get through to the list, it just requires a moderation delay on the first time an email address is seen.