Re: [libvirt] [PATCH 10/21] Don't let parent of daemon exit until basic initialization is done
On Wed, Oct 28, 2009 at 03:22:38PM +0100, Guido G?nther wrote:
Hi Daniel,
On Fri, Oct 23, 2009 at 02:05:39PM +0100, Daniel P. Berrange wrote:
> The daemonizing code lets the parent exit almost immediately. This
> means that it may think it has successfully started even when
> important failures occur like not being able to acquire the PID
> file. It also means network sockets are not yet open.
With this patch applied to 0.7.2 I'm seeing:
# libvirtd -d
15:20:22.457: error : main:2971 : Failed to fork as daemon: Success
about every second time I start the daemon. Any idea where this comes
from?
No, but that sounds bad to me - something I'm not expecting must be
going on here. Definitely sounds like a race condition.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|