Re: [libvirt] [PATCH 2/2] qemu: Support setting the 'removable' flag for USB disks
Hi,
Add an attribute named 'removable' to the 'target'
element of disks,
which controls the removable flag. For instance, on a Linux guest it
controls the value of /sys/block/$dev/removable. This option is only
valid for USB disks (i.e. bus='usb'), and its default value is 'off',
which is the same behaviour as before.
For what it's worth, I have been successfully using this patchset in
production since March, in its various incarnations.
More specifically, I have been running libvirt 1.1.0 + the latest
patches proposed on July 25th since they were submitted, have been
heavily using emulated USB devices, and I have not experienced
any issue.
My reading of the situation is that the patches submitter has improved
his patches months ago after receiving initial feedback, and since
then the only activity I have seen was him porting his patches to the
latest libvirt code and re-submitting.
What is missing to get these patches merged, then?
(Apart of porting them to the latest version again, of course :)
Regards,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc