Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk

On Fri, May 15, 2020 at 05:08:23PM +0200, Ján Tomko wrote: > On a Friday in 2020, Gerd Hoffmann wrote: > > Add deprecation message to the audio init function. > > > > Factor out audio initialization and call that from > > both audio init and realize, so setting audiodev via > > -global is enough to properly initialize pcspk. > > > > Signed-off-by: Gerd Hoffmann <kraxel(a)redhat.com&gt; > > --- > > hw/audio/pcspk.c | 24 +++++++++++++++++++++--- > > 1 file changed, 21 insertions(+), 3 deletions(-) > > > > @@ -236,9 +245,18 @@ static const TypeInfo pcspk_info = { > > .class_init = pcspk_class_initfn, > > }; > > > > +static int pcspk_audio_init_soundhw(ISABus *bus) > > +{ > > + PCSpkState *s = pcspk_state; > > + > > + warn_report("'-soundhw pcspk' is deprecated, " > > + "please set a backend using '-global isa-pcspk.audiodev=<name>' instead"); > > + return pcspk_audio_init(s); > > -soundhw pcspk is the only soundhw device present in libvirt git. > > Is there a way to probe for this change via QMP? Oops. I'm surprised libvirt actually supports pcspk. There is no way to see that in qmp, and I can't think of an easy way to add that. Does libvirt check for command line switches still? So it could see -soundhw going away if that happens?