Re: [libvirt] [PATCH v2 2/7] util: Add API for converting virBitmap into printable string
On 02/22/2011 09:48 AM, Jiri Denemark wrote:
---
Notes:
Version 2:
- modified for unsigned long base type
+ while (sz--) {
+ virBufferVSprintf(&buf, "%0*lx",
+ VIR_BITMAP_BITS_PER_UNIT / 4,
+ bitmap->map[sz]);
Yep, that (int) cast in patch 1 makes sense now (I guessed this would be
the reason for the cast, which is why I didn't point it out on patch 1).
ACK.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)