On Tue, 2017-01-10 at 11:42 -0700, Jim Fehlig wrote:
Cédric Bosdonnat wrote:
> libxl doesn't provide a way to write one log for each domain. Thus
> we need to demux the messages. If our logger doesn't know to which
> domain to attribute a message, then it will write it to the default
> log file.
>
> Starting with Xen 4.9 (commit f9858025 and following), libxl will
> write the domain ID in an easy to grab manner. The logger introduced
> by this commit will use it to demux the libxl log messages.
>
> Thanks to the default log file, this logger will also work with older
> versions of Xen.
> ---
> * v4: delay the log file opening to the first message write.
Hmm, in hindsight I shouldn't have mentioned this in V3 since we'll always have
at least the json config written to the file correct? If so, there's really no
reason to delay opening it. Sorry for the confusion.
I tend to prefer V3, but with the nits I pointed out there fixed :-).
Then I pushed the v3 with the changes.
--
Cedric