Re: [Libvir] PATCH: Support network interface model in Xen and QEMU driver
On Wed, Apr 30, 2008 at 07:27:41PM +0200, Soren Hansen wrote:
On Wed, Apr 30, 2008 at 12:43:06PM +0100, Daniel P. Berrange wrote:
> And Ubuntu have already shipped a product with a patch using this
> syntax applied, so we can't reasonably change it.
Ironically, I'm with Daniel Veillard on this one. Sure, it'd be nice if
it was factored into the decision to some extent, but I'd be sad if I
have somehow short-circuited the development process by forcing this
decision onto the rest of you guys. I clearly read too much into the
fact that Richard had posted a patch that used this syntax and noone
objected. My bad entirely, and I'll deal with the mess it causes.
WRT to the network interface type attribute, I advised Soren at the
virt summit in Austin, that since Rich Jones had already posted the
patch and we'd all basically agreed on syntax it was reasonably to
include the patch in Ubuntu. It was only a matter of time before we
merged it - as I have done today.
Now, the disk model syntax supporting virtio is where I agree with Daniel
that it should have been posted upstream before inclusion in a product Even
if the code was just a quick hack, not in a state fit for merging - it is
always beneficial to post as early as possible just for the sake of
visibility & comment. This said I believe the proposed 'bus' atribute for
disks is the optimal way to handle virtio for disks. Just for future
enhancements please post ideas to this list asap. I myself have posted
ideas more than 1 year before actually getting around to implementing
them, so there's no requirement to follow through with code immediately :-)
Dan.
--
|: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|