Hi Philippe,
On Tue, Mar 05, 2024 at 02:42:04PM +0100, Philippe Mathieu-Daudé wrote:
Date: Tue, 5 Mar 2024 14:42:04 +0100
From: Philippe Mathieu-Daudé <philmd(a)linaro.org>
Subject: [PATCH-for-9.1 02/18] hw/usb/hcd-xhci: Enumerate xhci_flags
setting values
X-Mailer: git-send-email 2.41.0
xhci_flags are used as bits for QOM properties,
expected to be somehow stable (external interface).
Explicit their values so removing any enum doesn't
modify the other ones.
Signed-off-by: Philippe Mathieu-Daudé <philmd(a)linaro.org>
---
hw/usb/hcd-xhci.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/usb/hcd-xhci.h b/hw/usb/hcd-xhci.h
index 98f598382a..37f0d2e43b 100644
--- a/hw/usb/hcd-xhci.h
+++ b/hw/usb/hcd-xhci.h
@@ -37,8 +37,8 @@ typedef struct XHCIEPContext XHCIEPContext;
enum xhci_flags {
XHCI_FLAG_SS_FIRST = 1,
- XHCI_FLAG_FORCE_PCIE_ENDCAP,
- XHCI_FLAG_ENABLE_STREAMS,
+ XHCI_FLAG_FORCE_PCIE_ENDCAP = 2,
+ XHCI_FLAG_ENABLE_STREAMS = 3,
};
From the commit 290fd20db6e0 ("usb xhci: change msi/msix property
type"), the enum values were modified directly.
So it seems not necessary to bind enum type with specific value,
right?
Thanks,
Zhao