Re: [libvirt] [PATCH v2 RESEND 00/17] Introduce RDT memory bandwidth allocation support

On 07/30/2018 11:54 PM, bing.niu wrote: > > > On 2018年07月31日 06:14, John Ferlan wrote: >> >> >> On 07/29/2018 11:12 PM, bing.niu(a)intel.com wrote: >>> From: Bing Niu <bing.niu(a)intel.com&gt; >>> >>> This series is to introduce RDT memory bandwidth allocation support >>> by extending >>> current virresctrl implementation. > > [....] >>> Bing Niu (17): >>>    util: Rename some functions of virresctrl >>>    util: Refactor virResctrlGetInfo in virresctrl >>>    util: Refactor virResctrlAllocFormat of virresctrl >>>    util: Add MBA capability information query to resctrl >>>    util: Add MBA check to virResctrlInfoGetCache >>>    util: Add MBA allocation to virresctrl >>>    util: Add MBA schemata parse and format methods >>>    util: Add support to calculate MBA utilization >>>    util: Introduce virResctrlAllocForeachMemory >>>    util: Introduce virResctrlAllocSetMemoryBandwidth >>>    conf: Rename cachetune to resctrl >>>    conf: Factor out vcpus parsing part from virDomainCachetuneDefParse >>>    conf: Factor out vcpus overlapping from virDomainCachetuneDefParse >>>    conf: Factor out virDomainResctrlDef update from >>>      virDomainCachetuneDefParse >>>    conf: Add support for memorytune XML processing for resctrl MBA >>>    conf: Add return value check to virResctrlAllocForeachCache >>>    conf: Add memory bandwidth allocation capability of host >>> >>>   docs/formatdomain.html.in                          |  39 +- >>>   docs/schemas/capability.rng                        |  33 ++ >>>   docs/schemas/domaincommon.rng                      |  17 + >>>   src/conf/capabilities.c                            | 107 ++++ >>>   src/conf/capabilities.h                            |  11 + >>>   src/conf/domain_conf.c                             | 428 >>> ++++++++++++--- >>>   src/conf/domain_conf.h                             |  10 +- >>>   src/libvirt_private.syms                           |   6 +- >>>   src/qemu/qemu_domain.c                             |   2 +- >>>   src/qemu/qemu_process.c                            |  18 +- >>>   src/util/virresctrl.c                              | 611 >>> +++++++++++++++++++-- >>>   src/util/virresctrl.h                              |  55 +- >>>   .../memorytune-colliding-allocs.xml                |  30 + >>>   .../memorytune-colliding-cachetune.xml             |  32 ++ >>>   tests/genericxml2xmlindata/memorytune.xml          |  33 ++ >>>   tests/genericxml2xmltest.c                         |   5 + >>>   .../linux-resctrl/resctrl/info/MB/bandwidth_gran   |   1 + >>>   .../linux-resctrl/resctrl/info/MB/min_bandwidth    |   1 + >>>   .../linux-resctrl/resctrl/info/MB/num_closids      |   1 + >>>   tests/vircaps2xmldata/vircaps-x86_64-resctrl.xml   |   8 + >>>   tests/virresctrldata/resctrl.schemata              |   1 + >>>   21 files changed, 1280 insertions(+), 169 deletions(-) >>>   create mode 100644 >>> tests/genericxml2xmlindata/memorytune-colliding-allocs.xml >>>   create mode 100644 >>> tests/genericxml2xmlindata/memorytune-colliding-cachetune.xml >>>   create mode 100644 tests/genericxml2xmlindata/memorytune.xml >>>   create mode 100644 >>> tests/vircaps2xmldata/linux-resctrl/resctrl/info/MB/bandwidth_gran >>>   create mode 100644 >>> tests/vircaps2xmldata/linux-resctrl/resctrl/info/MB/min_bandwidth >>>   create mode 100644 >>> tests/vircaps2xmldata/linux-resctrl/resctrl/info/MB/num_closids >>> >> >> Reviewed-by: John Ferlan <jferlan(a)redhat.com&gt; >> (series) >> >> I'll push once the tree is open for 4.7.0 commits unless someone else >> chimes in with other major issues that need to be addressed. >> > Tree re-opened after I left for a week away from the virtual world... Now that I'm back and digging out of email, figured I'd sync this series up with current top and push. Please post a followup docs/news.xml article describing the change.

Tks - John