Re: [libvirt] [PATCH] keycodemapdb: Update submodule
On Mon, Mar 12, 2018 at 03:53:09PM +0100, Andrea Bolognani wrote:
On Mon, 2018-03-12 at 14:46 +0000, Daniel P. Berrangé wrote:
> > The build system doesn't get refreshed automatically after this
> > change, so it's still trying to generate virkeycodetable_rfb.h
> > and failing because the current version of keymap-gen doesn't know
> > about it.
>
> Perhaps it would be better if I just made 'keymap-gen' continue to
> accept 'rfb' as a deprecated alias for 'qnum'
That would probably be nice regardless, but it wouldn't really help
here - unless we decided to stick with the old name in libvirt too.
Are you advocating for doing just that?
No, just take your patch as is. Just fix keymap-gen, so we make the
(harmless) error message disappear for people with existing checkouts
that have built the old filename.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|