Re: [libvirt] Allowing <interface type="none"> for network interface definition

Daniel P. Berrange wrote: Hi Daniel Thanks for the reply by using type=none what I meant was asking qemu-dm not to make any configurations what so ever. so I am asking qemu-dm to not to present a network card to vm at all.. This is some code segments I took out from xend_internal. c if (def->ifname != NULL && !STRPREFIX(def->ifname, "vif")) virBufferVSprintf(buf, "(vifname '%s')", def->ifname); if (def->model != NULL) virBufferVSprintf(buf, "(model '%s')", def->model); So the model tag is already send to xend, and used in xend as well check the following xend code for devuuid in vmConfig['vif_refs']: devinfo = vmConfig['devices'][devuuid][1] dtype = devinfo.get('type', 'ioemu') if dtype != 'ioemu': continue nics += 1 mac = devinfo.get('mac') if mac is None: raise VmError("MAC address not specified or generated.") bridge = devinfo.get('bridge', 'xenbr0') model = devinfo.get('model', 'rtl8139') ret.append("-net") ret.append("nic,vlan=%d,macaddr=%s,model=%s" % (nics, mac, model)) ret.append("-net") ret.append("tap,vlan=%d,ifname=tap%d.%d,bridge=%s" % (nics, self.vm.getDomid(), nics-1, bridge)) if nics == 0: ret.append("-net") ret.append("none") Therefore only way I can achieve -net none switch, is by sending a (type != ioemu ) tag. sending in a ( model ) tag will not give me what I want. So simply I just want to update my xenstore configuration but I am going to ask qemu not to load any network at all.. So as far as qemu is concerned the domain does not have any network.. -net none. That's what I thought of using something like <interface type="none">. Am I missing something here.. Just to let you know, This is what I changed on the level of xend_internal.c if ((hvm) && (xendConfigVersion < 4) && (def->type!=VIR_DOMAIN_NET_TYPE_NONE)) virBufferAddLit(buf, "(type ioemu)"); else{ //Only send type none if the <interface type="none" vm formats> virBufferAddLit(buf, "(type none)"); } I need to send a explicit (type none) or any ( type !ioemu) to get the desired outcome. Thought none would make sense as I don't want any network configured Thanks Gihan