Re: [libvirt] [PATCH v2 2/5] rpc: add testing of RPC JSON (de)serialization
On Fri, Jun 05, 2015 at 09:46:24AM +0100, Daniel P. Berrange wrote:
On Thu, Jun 04, 2015 at 07:35:09PM +0200, Martin Kletzander wrote:
> From: "Daniel P. Berrange" <berrange(a)redhat.com>
>
> The virNetServer class has the ability to serialize its state
> to a JSON file, and then re-load that data after an in-place
> execve() call to re-connect to active file handles. This data
> format is critical ABI that must have compatibility across
> releases, so it should be tested...
>
> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
Sorry in my previous posting of this, I messed up and did not
send the two pre-requisite patches for allowing us to restrict
the address family usage, which is important for testCreateServer
to produce accurate results in dual ipv4/6 systems. I see you
have deleted that bit of code, but we still need it, so let
me just send the original patches again, and then we can just
re-add the bits to this version of yours.
I was wondering why you've replied with this on patch 2/5 and now I
see I forgot to reorder them. I'll push those other (ACKed) clean-ups
in a while.
About the address family usage, I couldn't find out what could the
problem be if the test would be ran on such hosts. However, I believe
you're right, so go ahead. I have changed only a minimum of your
code, so just send your version when it's ready. In the meantime I'll
use ththis version to rebase the Admin API series upon, so I can test
that it re-execs properly. I would really like for that to go in this
release.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)