Re: [libvirt] [PATCH v4 04/14] domain_conf: introduce virDomainGraphicsAddListenAddr
On Thu, May 19, 2016 at 03:58:58PM -0400, Cole Robinson wrote:
On 05/19/2016 07:35 AM, Pavel Hrdina wrote:
> Move code that decide whether we print the 'listen' attribute or not
> into virDomainGraphicsAddListenAddr() function.
>
> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
> ---
> src/conf/domain_conf.c | 59 +++++++++++++++++++++++++++++---------------------
> 1 file changed, 34 insertions(+), 25 deletions(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index b1b2bb9..b3b60f1 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -21397,13 +21397,43 @@ virDomainGraphicsListenDefFormat(virBufferPtr buf,
> }
>
>
> +/**
> + * virDomainGraphicsAddListenAddr:
The naming confused me, how about virDomainGraphicsListenDefFormatAddr? To
follow the previous function name of virDomainGraphicsListenDefFormat. Just
something with Format in it at least
Sure, that's a better name.
Also this patch makes me realize we totally lack MIGRATABLE xml
tests, but
that can be additive.
I've noticed that too and we definitely need those tests to not break migration.
ACK
Thanks