Re: [libvirt] [PATCH v3 6/7] virsh: add function to get the CPU models for an arch

On 09/13/2013 03:06 PM, Eric Blake wrote: Jiri helped me on IRC. The list of arch names in 'virsh capabilities' is from a canonical list; but the list of arch names in /usr/share/libvirt/cpu_map.xml is a list of drivers (which can support one _or more than one_ canonical architecture). More precisely: $ grep 'arch ' /usr/share/libvirt/cpu_map.xml <arch name='x86'> <arch name='ppc64'> $ tools/virsh -c test:///default capabilities | grep 'arch ' <arch name='i686'> <arch name='i686'> this suggests that the 'x86' driver knows how to manage both the 'i686' and 'x86_64' architectures. So ideally, qemu-system-x86_64 should support 'virsh cpu-models x86_64' and 'virsh cpu-models i686' with identical lists (after all, x86_64 chips can run in i686 mode), while the test driver (which claims support for ONLY i686) might want to fail for x86_64. Furthermore, with your patches as-is, 'virsh cpu-models x86' returned a list; but I don't think this is appropriate as that name is not in the capabilities output. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org