Re: [libvirt] [PATCH v8 10/11] util: Add virstoragetest to parse/format a tls='yes'
On Thu, Sep 14, 2017 at 08:51:55 -0400, John Ferlan wrote:
From: Ashish Mittal <Ashish.Mittal(a)veritas.com>
Add a test case to verify TLS arguments are parsed correctly for
a VxHS disk. This includes saving off a found tls-creds into the
storage source @tlsAlias field since that's what's used to link
the TLS object for the authentication credentials and the disk.
Test case verifies that XML is generated correctly for a VxHS disk
having TLS enabled.
Signed-off-by: Ashish Mittal <Ashish.Mittal(a)veritas.com>
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
src/util/virstoragefile.c | 9 +++++++++
tests/virstoragetest.c | 12 ++++++++++++
2 files changed, 21 insertions(+)
It's useless to parse this from the backign store strings. It might be
useful if we'd parse it from qemu, but we don't.
This needs to be setup each time anyways by libvirt and the alias may
become stale.
NACK
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)