30 May
2014
30 May
'14
9:36 p.m.
On 05/30/2014 12:21 AM, Ján Tomko wrote:
+ if (nodename && + !(virSocketAddrParse(&tmp_addr, nodename, AF_UNSPEC) > 0 && + virSocketAddrIsWildcard(&tmp_addr))) + hints.ai_flags = AI_ADDRCONFIG;
Shouldn't this be |= ?
Functionally it's the same, AI_PASSIVE is ignored if nodename is non-NULL.
But it should be |= if we were using other flags.
Okay. ACK to the patch, and safe to include in 1.2.5. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org