Re: [libvirt] [PATCH] Fix generating python bindings
On Thu, Feb 12, 2009 at 02:37:46PM -0500, Cole Robinson wrote:
The recent API additions virSaveLastError and virFreeError upset the
python bindings generator. Add a rule to explicitly skip them for the
bindings, since (as far as I can tell) the libvirtError class provides
everything we need.
Correct, this is not required for python layer, since we turn the
thread local error straight into an exception object the moment
we get it.
diff --git a/python/generator.py b/python/generator.py
index 9c71c05..0e8cca7 100755
--- a/python/generator.py
+++ b/python/generator.py
@@ -344,6 +344,8 @@ skip_function = (
'virDefaultErrorFunc', # Python virErrorFuncHandler impl calls this from C
'virConnectDomainEventRegister', # overridden in virConnect.py
'virConnectDomainEventDeregister', # overridden in virConnect.py
+ 'virSaveLastError', # We have our own python error wrapper
+ 'virFreeError', # Only needed if we use virSaveLastError
)
ACK
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|