Re: [libvirt] [PATCH v4] virt-aa-helper: Set the supported features

On Tue, Feb 6, 2018 at 2:42 PM, Peter Krempa <pkrempa(a)redhat.com&gt; wrote: > On Tue, Feb 06, 2018 at 08:08:14 -0500, Shivaprasad G Bhat wrote: >> The virt-aa-helper fails to parse the xmls with the memory/cpu >> hotplug features or user assigned aliases. Set the features in >> xmlopt->config for the parsing to succeed. >> >> Signed-off-by: Shivaprasad G Bhat <sbhat(a)linux.vnet.ibm.com&gt; >> --- >> src/conf/domain_conf.h | 2 ++ >> src/security/virt-aa-helper.c | 8 +++++++- >> 2 files changed, 9 insertions(+), 1 deletion(-) > > ACK from my side, but I'll wait for a while for the debian/ubuntu guys > chiming in. I had a review and test on v2. This essentially differes by a comment that I also requested - so still ack. Tested-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com&gt; Reviewed-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com&gt;

P.S. you could say I'm an Ubuntu guy :-)