On 12/10/2012 02:23 PM, Laine Stump wrote:
virNetworkDefUpdateForward requires separate functions to parse and
clear a virNetworkForwardDef by itself, but they were previously just
inlined in the virNetworkDef parse and free functions. This patch
makes them into separate functions.
---
src/conf/network_conf.c | 515 ++++++++++++++++++++++++++----------------------
1 file changed, 280 insertions(+), 235 deletions(-)
Again looks big, but turns out to be mostly code motion and some added
boilerplate. ACK.
- break;
+ if (def->bridge && (def->forward.nifs || def->forward.npfs)) {
+ virReportError(VIR_ERR_XML_ERROR,
+ _("A network with forward mode='%s' can specify
"
+ "a bridge name or a forward dev, but not "
Two spaces.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org