Re: [libvirt] [PATCH] tests: skip qemublocktest if building without YAJL
On Tue, 2018-09-04 at 13:05 +0100, Daniel P. Berrangé wrote:
> > Pushed as a build fix for platforms without JSON parser
installed
>
> Which platforms? All machines in our CI environments should have
> yajl installed.
It wasn't CI - it was my own FreeBSD machine without yajl
I see someone hasn't been using lcitool :P
> Either way, IIRC during the switch to Jansson we also made the
> JSON parser mandatory when building the QEMU driver, a change
> which I believe we might have reverted when switching back to
> yajl: can we just have that back? Or are there some issues
> preventing us from doing so?
All our other tests have WITH_YAJL checks in them, this one was the
exception. Possibly they could all be changed with WITH_QEMU
instead but that's more than I want todo as a build fix.
Fair enough. I still think we want to re-introduce the behavior
described above.
--
Andrea Bolognani / Red Hat / Virtualization