Re: Re: [libvirt PATCH 0/5] add loongarch support for libvirt
On Mon, Dec 18, 2023 at 11:40:03AM +0800, lixianglai wrote:
On Thu, Dec 14, 2023 at 02:08:44PM +0800, xianglai li wrote:
> Great to see that edk2 support has already been mainlined! An
> excellent next step would be to get an edk2-loongarch64 package into
> the various distros... Please consider working with the maintainers
> for edk2 in Fedora to make that happen, as it would significantly
> lower the barrier for interested people to get involved.
Yes, we will do that, currently the loongarch code is being moved from the
edk2-platform directory to the edk2 directory,
I think after this work is completed, we will have the edk2 installation
package.
I'm not very familiar with how the edk2 repository is maintained, but
that sounds like a good plan. Presumably an edk2 release will have to
be tagged as well.
> The /usr/share/qemu/ directory is owned by the QEMU package,
and
> other components should not drop their files in there. The exception
> is the /usr/share/qemu/firmware/ directory, which is specifically
> designed for interoperation.
>
> The edk2 files should be installed to /usr/share/edk2/loongarch64/,
> following the convention established by existing architectures. Once
> the directory name already contains architecture information, you can
> use shorter and less unique names for the files themselves.
I think edk2-loongarch64-code.fd can be the loongarch bios that comes with
the qemu package,
and then its installation path is /usr/share/qemu which makes sense.
Yes, but distro packages usually strip those bits and rely on
firmware packages being installed separately instead.
It's just a minor point. As long as support is still being merged
into the various upstream projects, testing things out is always
going to be messy. It will naturally become smoother over time :)
> The information provided in the cover letter, including pointers
to
> the various not-yet-upstreamed changes and instructions on how to
> test everything, is very much appreciated!
Ok, I will provide more detailed instructions on changes and testing in the
next version.
Personally I think that the information related to testing that
you've provided in the cover letter is quite extensive, so don't feel
that you necessarily need to expand upon it.
--
Andrea Bolognani / Red Hat / Virtualization