Re: [PATCH 5/8] virSecurityDACSetOwnershipInternal: Drop dead code
On 6/17/21 12:42 PM, Michal Privoznik wrote:
The virSecurityDACSetOwnershipInternal() function accepts two
arguments (among others): @path and @src. The idea being that in
some cases @path is NULL and @src is not and then @path is filled
from @src->path. However, this is done in both callers already
(because of seclabel remembering/recall). Therefore, this code in
virSecurityDACSetOwnershipInternal() is dead, effectively.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/security/security_dac.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
Similar dead code is also repeated in debug prints:
VIR_INFO("Restoring DAC user and group on '%s' to %ld:%ld",
NULLSTR(src ? src->path : path), (long)uid, (long)gid);
For the next time you get in a cleaning mood ;)
Jano