On 06/09/2010 06:08 AM, Daniel P. Berrange wrote:
On Wed, Jun 09, 2010 at 02:38:32AM +1000, Justin Clift wrote:
> This patch adds two new parameters to the vol-create-as command:
>
> --backing-vol <volume-name-or-key-or-path>
> --backing-vol-format <format-of-backing-vol>
>
> virsh # vol-create-as guest_images_lvm snapvol1 5G --backing-vol \
> rhel6vm1lun1
> Vol snapvol1 created
>
> virsh # vol-create-as image_dir qcow2snap2 5G --format qcow2 \
> --backing-vol imagevol1.qcow2 \
> --backing-vol-format qcow2
> Vol qcow2snap2 created
>
> Additionally, the virsh man page update fixes incorrect snapshot
> parameters that were included in my prior bulk volume command patch.
ACK, this looks fine to me
I've pushed this now.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org