Re: [libvirt] [PATCH 06/20] util: reject unknown flags

> int nodeGetMemoryStats(virConnectPtr conn ATTRIBUTE_UNUSED, > int cellNum, > virNodeMemoryStatsPtr params, > int *nparams, > - unsigned int flags ATTRIBUTE_UNUSED); > + unsigned int flags); > int nodeGetCellsFreeMemory(virConnectPtr conn, > unsigned long long *freeMems, > int startCell, Hummm, shouldn't we forbid ATTRIBUTE_UNUSED from .h forward declarations and keep them only in the actual implementation block. I don't think it's a good idea to expos this to the compiler who might make an optimization there seeing it in the .h while the equivalent implementation may have removed it.