Re: [libvirt] [PATCH 4/8] conf: Allow NULL for virDomainDeviceInfoCallback

On Wed, May 22, 2019 at 03:36:59PM +0200, Andrea Bolognani wrote: > I don't much like the idea of adding a separate function that does > almost the same thing but not quite, because that will ultimately > result in the same situation we have now: someone will add a new > callback and (reasonably) expect it to be called for all devices, > but that won't happen because the original code uses the DeviceInfo > variant instead of the Device one. That's unnecessary friction. So is having to argue about not putting if (!info) into every single internal function that should not have been called with a NULL info in the first place.