Re: [libvirt] [PATCHv3 1/2] VMware: Support more than 2 driver backends
On Tue, Sep 24, 2013 at 11:24:30AM -0500, Doug Goldstein wrote:
Currently the VMware version check code only supports two types of
VMware backends, Workstation and Player. But in the near future we will
have an additional one so we need to support more. Additionally, we
discover and cache the path to the vmrun binary so we should use that
path when using the cooresponding binary from the VMware VIX SDK.
---
change from v2:
* No change
change from v1:
* Added default case so we don't potentially pass NULL to virCommand
Since it adds a new product support with very little changes,
looks (IMHO) safe and Matthias looks fine with it, I'm okay to
have those two patches pushed for 1.1.3.
So please make the few changes suggested by Matthias, and push
preferably today as I would like to make rc2 over the week-end,
thanks !
Daniel
--
Daniel Veillard | Open Source and Standards, Red Hat
veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | virtualization library http://libvirt.org/