Re: [libvirt] [PATCH] qemu: qxl devices don't support multifunction yet
Hi
----- Original Message -----
At 09/15/2011 08:23 PM, Marc-André Lureau Write:
> Hi Daniel
>
> On Thu, Sep 15, 2011 at 10:18 AM, Daniel P. Berrange
> <berrange(a)redhat.com> wrote:
>> This isn't really desirable, because our PCI device address
>> tracking
>> code is still going to allow other devices to share the slot with
>> QXL, and not know that the ARGV has been hacked to disable
>> multifunction.
>
> How do we allow other devices to share the slot? It seems to me that
> qemuDomainPCIAddressSetNextAddr() only allocate whole slot, while
> making sure there is no conflicts on the same slot.
So, if the user wants to use multi function pci device, he should
specify the
pci address.
So adding a check such as:
if (!multiFunc && info->addr.pci.function != 0)
return error("The %s device doesn't support multifunction address")
Should be enough?
regards
--
Marc-André Lureau