On Monday, 19 October 2020 14:22:24 CEST Peter Krempa wrote:
<name> is mandatory for a domain XML. Add 'displayName'
for all the test
cases which were missing them so that <name> is parsed correctly.
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
[...]
diff --git a/tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx
b/tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx
index 8641c5c01b..dd069b378d 100644
--- a/tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx
+++ b/tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx
@@ -49,3 +49,4 @@ UUID.LOCATION = "56 4D B5 06 A2 BD FB EB-AE 86 F7 D8 49 27 D0
C4"
SCHED.CPU.MAX = "UNLIMITED"
SCHED.SWAP.DERIVEDNAME =
"/VMFS/VOLUMES/498076B2-02796C1A-EF5B-000AE484A6A3/FEDORA11/FEDORA11-7DE040D8.VSWP"
TOOLS.REMINDINSTALL = "TRUE"
+displayName = "test"
diff --git a/tests/vmx2xmldata/vmx2xml-case-insensitive-2.vmx
b/tests/vmx2xmldata/vmx2xml-case-insensitive-2.vmx
index a485d03cd9..e37e0b9369 100644
--- a/tests/vmx2xmldata/vmx2xml-case-insensitive-2.vmx
+++ b/tests/vmx2xmldata/vmx2xml-case-insensitive-2.vmx
@@ -49,3 +49,4 @@ uuid.location = "56 4d b5 06 a2 bd fb eb-ae 86 f7 d8 49 27 d0
c4"
sched.cpu.max = "unlimited"
sched.swap.derivedname =
"/vmfs/volumes/498076b2-02796c1a-ef5b-000ae484a6a3/fedora11/fedora11-7de040d8.vswp"
tools.remindinstall = "true"
+displayName = "test"
Are you sure about these two? They have already displayName, albeit
with a different captalization, and indeed this patch has no changes
to their xml result files.
With the above two removed:
Reviewed-by: Pino Toscano <ptoscano(a)redhat.com>
--
Pino Toscano