Re: [libvirt] [PATCH] S390: Fix virSysinfoRead memory corruption
On 12/07/2012 10:44 AM, Daniel P. Berrange wrote:
1 files changed, 69 insertions(+), 91 deletions(-)
Given the complexity the parsing it would be nice to add a test
case for this. It is a shame we don't already have a test case
for the sysinfo code in fact :-( I'd like to see test/virsysinfotest.c
to validate this parsing. Take a 'char *str' containing representation
data from /proc/sysinfo, run it through the parser & then validate the
result.
Daniel
Makes sense ... as this is platform-specific (ifdef'd) code: should I
try to (by refactoring) make the s390 code testable on other platforms
or do you think it's sufficient to have make check execute the test
case on the target platform only, e.g. during RPM build.
Either way: the checks for DMI-based sysinfo and PPC would have to be
provided by the respective authors...
--
Mit freundlichen Grüßen/Kind Regards
Viktor Mihajlovski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294