Re: [libvirt] [PATCH 5/7] util: Add ADD_ARG_RETURN_ON_ERROR

> +#define ADD_ARG_RETURN_ON_ERROR(rule, str) \ > + do { \ > + if (VIR_RESIZE_N(rule->args, \ > + rule->argsAlloc, \ > + rule->argsLen, 1) < 0) \ > + return; \ > + \ > + rule->args[rule->argsLen++] = g_strdup(str); \ > + } while (0) IMHO this is missing the benefit of using glib since VIR_RESIZE_N will never fail now. We should get rid of "ADD_ARG" entirely, and just put a g_realloc() call directly in the place it is needed without any macros. Likewise for the next patch.