Re: [libvirt] [PATCH 0/6] syntax-check: Introduce a new rule to check misaligned stuff and fix it (batch I)

On Mon, Sep 24, 2018 at 10:15:22AM +0200, Michal Privoznik wrote: > On 09/19/2018 10:38 AM, Shi Lei wrote: >> This series check misaligned stuff in parenthesis: >> 1. For misaligned arguments of function >> 2. For misaligned conditions of [if|while|switch|...] >> >> It adds a temporary filter for this new rule since there're >> too much misalignment. >> Now it just fix misalignment in src/util and it's the batch I. >> Next step, we need modify this path filter to finish all changes. >> >> Also, it simplifies the check-spacing.pl by adding wrapper functions >> before introducing the new rule. >> >> Thanks, >> >> Shi Lei >> >> Shi Lei (6): >>   util: Fix misaligned arguments and misaligned conditions for >>     [if|while|...] >>   build-aux:check-spacing: Add wrapper function of CheckFunctionBody >>   build-aux:check-spacing: Add wrapper function of KillComments >>   build-aux:check-spacing: Add wrapper function of CheckWhiteSpaces >>   build-aux:check-spacing: Add wrapper function of CheckCurlyBrackets >>   build-aux:check-spacing: Introduce a new rule to check misaligned >>     stuff in parenthesises >> > > Yay! ACKed and pushed. > > We definitely want more of these. > Please no. Despite my comments on the first spacing rule [0], this series slows down the spacing check by 100 % (from 1.6s to 3.1s in my case).

For such slowdown I'd expect more than just catching a few corner cases. Also note that a significant part of the slowdown is introduced by the wrapper functions.