Re: [libvirt] [PATCH 00/13] Move functions from qemu_domain_address.c to domain_addr.c

On 07/19/2016 08:07 PM, Tomasz Flendrich wrote: The problem is that many/most these functions are by definition qemu-specific - only the qemu driver has any concept of a Q35 machinetype or a PIIX3 controller (actually that function should probably have used "i440fx" instead of PIIX3) or an aarch64 "virt" machinetype, or any use for a "busNr" etc etc. So moving them from qemu into conf is busy-work that is counter-productive. I guess you're wanting to move these into conf because they are related to and used by functions that are assigning/allocating PCI addresses, and you want that to be done in a driver-agnostic place. I don't think simply moving all these driver-specific functions into driver-agnostic files and declaring them driver-agnostic is the right approach though. The "pre-loading/validation" of addresses in these functions based on hardware and qemu capabilities should either be called from qemu-specific code prior to calling a driver-agnostic address allocation/assignment function, or the driver-agnostic function should do a callback back into qemu to pre-load/validate the addresses. Beyond that, each PCI controller needs flags to indicate what type of slots (and how many) it provides, which is driver-specific and so needs to be provided by a callback into a driver-specific function, and as each device is assigned we need to determine what type of slot it can plug into, which will also be driver-specific and thus require a callback into a driver-specific function. This (functions to provide the slot-type-compatibility flags for controllers and devices) was something I was about to work on before I left for a two week vacation that turned into 3 due to "social unrest" (and I've now spent nearly a week just catching up on email). I have a lot of accumulated bits of knowledge about this in my brain that I need to dump into code, the sooner the better.