Re: [PATCH] spec: keep existing nwfilters uuid on update

On 10/26/20 10:21 AM, Nikolay Shirokovskiy wrote: > -cp %{_datadir}/libvirt/nwfilter/*.xml %{_sysconfdir}/libvirt/nwfilter/ > +# keep existing filters uuid on update > +for dfile in %{_datadir}/libvirt/nwfilter/*.xml; do > + sfile=%{_sysconfdir}/libvirt/nwfilter/`basename $dfile` > + if [ -f "$sfile" ]; then > + uuidstr=`sed -n '/<uuid>.*<\/uuid>/p' "$sfile"` > + if [ ! -z "$uuidstr" ]; then > + sed -e "s,<filter .*>,&\n$uuidstr," "$dfile" > "$sfile" > + continue > + fi > + fi > + cp "$dfile" "$sfile" > +done I wonder if we should treat these .xml files as config files. I mean, they can be changed by user and if they have been we should not touch them at update no matter what. But if they haven't, then we should replace them because they may contain new, better rules. I've read spec file documentation here and it looks like %config(noreplace) is doing just that: https://rpm-packaging-guide.github.io/#more-on-macros Would that solve the issue?