On Wed, Nov 30, 2016 at 09:33:54 -0600, Eric Blake wrote:
On 11/29/2016 01:59 PM, Jiri Denemark wrote:
> We can't change feature names for compatibility reasons even if they
> contain typos or other software uses different names for the same
> features. By adding alternative spellings in our CPU map we at least
> allow anyone to grep for them and find the correct libvirt's name.
>
> Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
> ---
> src/cpu/cpu_map.xml | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml
> index 8f366861a..b0233521a 100644
> --- a/src/cpu/cpu_map.xml
> +++ b/src/cpu/cpu_map.xml
> @@ -97,10 +97,10 @@
> </feature>
>
> <!-- standard features, ECX -->
> - <feature name='pni'>
> + <feature name='pni'> <!-- sse3 -->
> <cpuid eax_in='0x01' ecx='0x00000001'/>
> </feature>
Could we enhance the XML to allow zero or more aliases, as in:
<feature name='pni'>
<alias name='sse3'>
<cpuid ...>
</feature>
I think that's just overkill since I don't believe we want to allow
users to actually start using the aliases when interacting with libvirt.
Jirka