[PATCH v2 12/27] virsh: cmdSecretGetValue: Use virSecureErase instead of VIR_DISPOSE_N
Switch the secret value to 'g_autofree' for handling of the memory and
clear it out using virSecureErase.
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
tools/virsh-secret.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/virsh-secret.c b/tools/virsh-secret.c
index e413af893f..de32f25d64 100644
--- a/tools/virsh-secret.c
+++ b/tools/virsh-secret.c
@@ -303,7 +303,7 @@ cmdSecretGetValue(vshControl *ctl, const vshCmd *cmd)
{
g_autoptr(virshSecret) secret = NULL;
VIR_AUTODISPOSE_STR base64 = NULL;
- unsigned char *value;
+ g_autofree unsigned char *value = NULL;
size_t value_size;
bool plain = vshCommandOptBool(cmd, "plain");
@@ -315,7 +315,7 @@ cmdSecretGetValue(vshControl *ctl, const vshCmd *cmd)
if (plain) {
if (fwrite(value, 1, value_size, stdout) != value_size) {
- VIR_DISPOSE_N(value, value_size);
+ virSecureErase(value, value_size);
vshError(ctl, "failed to write secret");
return false;
}
@@ -325,7 +325,7 @@ cmdSecretGetValue(vshControl *ctl, const vshCmd *cmd)
vshPrint(ctl, "%s", base64);
}
- VIR_DISPOSE_N(value, value_size);
+ virSecureErase(value, value_size);
return true;
}
--
2.29.2