Re: [libvirt] [PATCH] Improve error reporting for virConnectGetHostname calls

Cole Robinson wrote: > > static int umlListDomains(virConnectPtr conn, int *ids, int nids) { > diff --git a/src/util/util.c b/src/util/util.c > index 98f8a14..49eac6d 100644 > --- a/src/util/util.c > +++ b/src/util/util.c > @@ -1804,30 +1804,42 @@ int virDiskNameToIndex(const char *name) { > #define AI_CANONIDN 0 > #endif > > -char *virGetHostname(void) > +char *virGetHostname(virConnectPtr conn) To be honest, I'm not sure we even need to add the "conn" parameter here. I seem to remember DanB saying that it was only needed in very few circumstances anymore. Can't we just call "virReportSystemError(NULL)", etc? That keeps this function signature a bit simpler. (It's not a deal-breaker in any case, just nice to not have to require this parameter)