Re: [libvirt] [PATCH 2/7] util: Fix regression introduced by commit 4360a098441
On 08/05/13 21:23, John Ferlan wrote:
On 05/06/2013 08:45 AM, Osier Yang wrote:
> Which refactored the old code, and introduced new helper
> virIsCapableVport, but the path for checking with access() is not
> correctly constructed.
I'd like to make a couple of suggestions...
This issue is/was because "LINUX_SYSFS_VPORT_CREATE_POSTFIX" didn't get
refactored into the new code (e.g. "/vport_create")
There is a enum in virutil.h
enum {
VPORT_CREATE,
VPORT_DELETE,
};
So why not create a "SYSFS_VPORT_CREATE_POSTFIX" symbol in virutil.c
like there is a refactored "SYSFS_FC_HOST_PATH" symbol...
Not sure if it's caused by the enum was introduced later than
the refactoring, so I missed it.
Then since the "LINUX_" versions of those symbols in
src/node_device/node_device_driver.h are no longer used, they could be
removed from there as well.
I will make a nother patch to clean up it.
Thanks.