Re: [PATCH v2 2/2] vsh: Define HAVE_STDARG_H before including readline

On 9/3/20 4:24 AM, Michal Privoznik wrote: > +/* In order to have proper rl_message declaration with older > + * versions of readline, we have to declare this. See 9ea3424a178 > + * for more info. */ > +# define HAVE_STDARG_H > # include <readline/readline.h> > # include <readline/history.h> > #endif How common is it for library .h files to assume autotools-style HAVE_* and WITH_* flags are defined? I'm just wondering if this particular failure is just one instance that's indicating a more general problem.